Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(devx): Removed CTF challenges till we can deploy them on testnet #4089

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

lucas-tortora
Copy link
Contributor

Description of change

Removed CTF challenges till we can deploy them on the testnet. When we deploy please revert this commit.

Type of change

  • Documentation Fix

How the change has been tested

Docs were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora lucas-tortora requested a review from a team as a code owner November 17, 2024 18:01
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 17, 2024
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@alexsporn
Copy link
Member

I removed from your branch the docker arm64 commit that was wrongly pushed to develop

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora changed the title test(devx): Removed CTF challenges till we can deploy them on testnet task(devx): Removed CTF challenges till we can deploy them on testnet Nov 17, 2024
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Painfully approving :(

@lucas-tortora lucas-tortora merged commit c530707 into develop Nov 18, 2024
33 of 34 checks passed
@lucas-tortora lucas-tortora deleted the devx/remove-ctf branch November 18, 2024 02:09
lucas-tortora added a commit that referenced this pull request Nov 18, 2024
salaheldinsoliman added a commit that referenced this pull request Nov 19, 2024
lucas-tortora added a commit that referenced this pull request Nov 19, 2024
* Revert "test(devx): Removed CTF challenges till we can deploy them on testnet (#4089)"

This reverts commit c530707.

* feat(devx) added package id for the CTF challenges

* fix package url

* update expected object types

* Apply suggestions from code review

Co-authored-by: vivekjain23 <165671934+vivekjain23@users.noreply.github.com>

* Update docs/content/developer/iota-move-ctf/challenge_1.mdx

---------

Co-authored-by: vivekjain23 <165671934+vivekjain23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants