Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): add theme route and polish view #4064

Merged
merged 13 commits into from
Nov 22, 2024
Merged

feat(wallet): add theme route and polish view #4064

merged 13 commits into from
Nov 22, 2024

Conversation

evavirseda
Copy link
Contributor

@evavirseda evavirseda commented Nov 14, 2024 •
edited
Loading

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4060

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested review from a team as code owners November 14, 2024 14:58
@evavirseda evavirseda self-assigned this Nov 14, 2024
@evavirseda evavirseda added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet labels Nov 14, 2024
@evavirseda evavirseda linked an issue Nov 14, 2024 that may be closed by this pull request
Add theme route and polish view #4060
Closed
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8ebb731

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-209cohq1v.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8ebb731

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-it3a4i4v4.vercel.app

@evavirseda evavirseda assigned evavirseda and unassigned evavirseda Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8ebb731

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-rcbgeyn9b.vercel.app

marc2332
marc2332 previously approved these changes Nov 15, 2024
View reviewed changes
Base automatically changed from tooling-wallet/add-theme-selection-logic to tooling-epic/add-darkmode-support-to-wallet November 15, 2024 10:08
@evavirseda
Merge branch 'tooling-epic/add-darkmode-support-to-wallet' into tooli…
d4c3431 
…ng-wallet/add-theme-route

apps/wallet/src/ui/app/components/menu/content/WalletSettingsMenuList.tsx
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4c3431

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-p1mavo5u6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4c3431

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-ro6iqp0q6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4c3431

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-oae6f3wbz.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3379d12

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-70j0k6dv4.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3379d12

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-6e3etoh7e.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3379d12

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-4gk2n0uex.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: cb6fc61

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-qhkapnbyt.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: cb6fc61

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-7coguniv5.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: cb6fc61

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-mgwotk2pn.vercel.app

brancoder
brancoder requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support for selection system theme 🙏

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e890e02

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-oiafq9jbc.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e890e02

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-d8y9aktql.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e890e02

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-nilk1c5b7.vercel.app

@evavirseda evavirseda requested a review from brancoder November 22, 2024 12:43
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 85bd646

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-kcktewxpw.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 85bd646

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-aqpx81h3b.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c898b83

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-8kyaluiwh.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c898b83

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-21rrvoz5x.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c898b83

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-j5h2jt06r.vercel.app

brancoder
brancoder approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@brancoder brancoder requested a review from marc2332 November 22, 2024 13:48
@marc2332 marc2332 merged commit bd3e08a into tooling-epic/add-darkmode-support-to-wallet Nov 22, 2024
33 checks passed
@marc2332 marc2332 deleted the tooling-wallet/add-theme-route branch November 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@brancoder brancoder brancoder approved these changes

Assignees

@evavirseda evavirseda

Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add theme route and polish view
3 participants
@evavirseda @marc2332 @brancoder