Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): add darkmode/lightmode theme selection logic #4053

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #3614

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested review from a team as code owners November 14, 2024 10:28
@evavirseda evavirseda self-assigned this Nov 14, 2024
@evavirseda evavirseda added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet labels Nov 14, 2024
@evavirseda evavirseda linked an issue Nov 14, 2024 that may be closed by this pull request
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2c08c7b

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-e3xde96f9.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2c08c7b

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-clqpoay7o.vercel.app

@evavirseda evavirseda marked this pull request as draft November 14, 2024 10:33
@evavirseda evavirseda marked this pull request as ready for review November 14, 2024 10:47
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a763367

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-bo6ccqh51.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a763367

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-dmgkt14gt.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a763367

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-91ac9p40v.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just some unused imports 🙏

@evavirseda evavirseda requested a review from brancoder November 14, 2024 12:56
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 065ede2

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-q25hzf4ee.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 065ede2

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-3pg0hl6xc.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 065ede2

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-d9l3atrxd.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 272124b

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-mbs5gr3sx.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 272124b

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-k50oubnp0.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 272124b

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-eg2etsrzj.vercel.app

@marc2332 marc2332 merged commit a6277f7 into tooling-epic/add-darkmode-support-to-wallet Nov 15, 2024
30 of 31 checks passed
@marc2332 marc2332 deleted the tooling-wallet/add-theme-selection-logic branch November 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add darkmode/lightmode theme selection logic
3 participants