Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): update fullnode deployment testnet & devnet configurations #4021

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

FranCerdan
Copy link
Contributor

@FranCerdan FranCerdan commented Nov 12, 2024

Description of change

Update documentation for Full node deployment.

Links to any relevant issues

#2135

Type of change

  • Documentation Fix

How the change has been tested

Deploying the fullnode on a VM.

@FranCerdan FranCerdan requested review from a team as code owners November 12, 2024 10:28
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 12, 2024
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@FranCerdan FranCerdan requested a review from shufps November 12, 2024 10:42
- ./iotadb:/opt/iota/db:rw
command: [
"/opt/iota/bin/iota-node",
"/usr/local/bin/iota-node",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please describe this change in the PR/issue why it's needed or why you do the adjustment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, with the old path, wasn't it actually working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the old path was not working, it showed the following error:

Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/opt/iota/bin/iota-node": stat /opt/iota/bin/iota-node: no such file or directory: unknown

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The origin "/opt/iota/bin/iota-node" works for me for my local built image. Which image do you use? Did you build the image via iota/docker/iota-node/build.sh by using ./build.sh -t iota-node --no-cache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image I'm using is the latest one build by the github CI/CD:
image: docker-registry.iota.org/iota-tools:v0.7.0-alpha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I was using the iota-tools, this image does not contain the binary at the /opt/iota/bin/iota-node, with iota-node the deployment works properly thanks for the feedback! I will update now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update done

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@shufps shufps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor Author

@FranCerdan FranCerdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR, with latest peer ID's

- ./iotadb:/opt/iota/db:rw
command: [
"/opt/iota/bin/iota-node",
"/usr/local/bin/iota-node",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image I'm using is the latest one build by the github CI/CD:
image: docker-registry.iota.org/iota-tools:v0.7.0-alpha

- ./iotadb:/opt/iota/db:rw
command: [
"/opt/iota/bin/iota-node",
"/usr/local/bin/iota-node",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I was using the iota-tools, this image does not contain the binary at the /opt/iota/bin/iota-node, with iota-node the deployment works properly thanks for the feedback! I will update now.

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@begonaalvarezd begonaalvarezd changed the title Doc: update fullnode deployment alphanet and testnet configurations task(devx): update fullnode deployment alphanet and testnet configurations Nov 14, 2024
@begonaalvarezd begonaalvarezd changed the title task(devx): update fullnode deployment alphanet and testnet configurations feat(docs): update fullnode deployment alphanet and testnet configurations Nov 14, 2024
@begonaalvarezd begonaalvarezd changed the title feat(docs): update fullnode deployment alphanet and testnet configurations feat(docs): update fullnode deployment testnet & devnet configurations Nov 14, 2024
@FranCerdan FranCerdan merged commit d5a3de6 into develop Nov 14, 2024
31 of 32 checks passed
@FranCerdan FranCerdan deleted the devops/update_deployment_documentation branch November 14, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants