feat: remove the v0 execution layer cut
#4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriyr
requested review from
a team,
miker83z and
kodemartin
as code owners
thibault-martinez
approved these changes
Nov 11, 2024
alexsporn
reviewed
Nov 11, 2024
| @@ -1526,7 +1526,7 @@ impl ProtocolConfig { | |||
|
|
|||
| gas_rounding_step: Some(1_000), | |||
|
|
|||
| execution_version: Some(1), | |||
| execution_version: Some(0), | |||
There was a problem hiding this comment.
Doesn't this break compatibility with current 0.7.0 networks?
There was a problem hiding this comment.
Yes, it breaks because I changed the protocol config which should be constant.
There was a problem hiding this comment.
Then as @lzpap proposed lets start with 1 instead of 0 and we keep compatibility.
There was a problem hiding this comment.
Fixed in ebfb035
Also, in this case, it is necessary to change the script which creates cuts.
The minimal versioned cut should be v1.
v0 will be considered as a feature cut since this change.
miker83z
approved these changes
Nov 11, 2024
Thoralf-M
reviewed
Nov 12, 2024
Thoralf-M
reviewed
Nov 12, 2024
valeriyr
force-pushed
the
sc-platform/issue-3983-remove-v0-cut
branch
from
ebfb035 to
8e65786
Compare
Thoralf-M
approved these changes
Nov 12, 2024
kodemartin
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
v0execution layer cut was removed.Also, the
latestversion changed to1to be compatible with the current protocol config.v0will be considered as a feature cut since this PR is merged.Links to any relevant issues
fixes #3983