feat(iota): don't require key generation for client.yaml if there is already one

[Thoralf-M]

Description of change

Don't require key generation for client.yaml if there is already one. This could happen for example if iota keytool import was used before

Links to any relevant issues

Fixes #3972

Type of change

• Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Running cargo run client active-address with only existing iota.keystore and iota.aliases in the iota_config folder.

[DaughterOfMars]

Given that this fn is called prompt_if_no_config, are we sure this is possible?

[Thoralf-M]

Given that this fn is called prompt_if_no_config, are we sure this is possible?

Yes, it happened to me with iota keytool import, prompt_if_no_config is not called there and should also not be called there as it doesn't require a client

[DaughterOfMars]

Given that this fn is called prompt_if_no_config, are we sure this is possible?

Yes, it happened to me with iota keytool import, prompt_if_no_config is not called there and should also not be called there as it doesn't require a client

But isn't this change in that function?

[Thoralf-M]

@DaughterOfMars I think I misunderstood you. The function is called prompt_if_no_config and it's checking inside if the config client.yaml exists, it doesn't check for iota.keystore.

[DaughterOfMars]

@DaughterOfMars I think I misunderstood you. The function is called prompt_if_no_config and it's checking inside if the config client.yaml exists, it doesn't check for iota.keystore.

Oh okay 👍