Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add generics section to the docs #3949

Merged
merged 3 commits into from
Nov 12, 2024
Merged

feat(docs): add generics section to the docs #3949

merged 3 commits into from
Nov 12, 2024

Conversation

salaheldinsoliman
Copy link
Contributor

Description of change

Added Generics section under iota-101

Links to any relevant issues

fixes #3749

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Enhancement

How the change has been tested

Docs built locally

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@salaheldinsoliman
feat(docs): add generics section to the docs
24b1330 
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
@salaheldinsoliman salaheldinsoliman requested a review from a team as a code owner November 7, 2024 12:51
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Vercel Preview Deployment is ready!

View Preview

@alexsporn alexsporn added the devx Issues related to the DevX team label Nov 8, 2024
@salaheldinsoliman
feat(docs): import generics and abilities from the Move Ref
cf69edf 
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Ginowine
Ginowine approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Ginowine Ginowine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@salaheldinsoliman salaheldinsoliman merged commit 0cd8f46 into develop Nov 12, 2024
31 of 32 checks passed
@salaheldinsoliman salaheldinsoliman deleted the devx/add-generics branch November 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@Ginowine Ginowine Ginowine approved these changes

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Generics section to the docs
4 participants
@salaheldinsoliman @Ginowine @lucas-tortora @alexsporn