chore: fix more 1.83 lints (#4750)

crates/iota-core/src/authority_aggregator.rs

@@ -1216,11 +1216,7 @@ where
     }
 
     /// Records the rpc error if it is.
-    fn record_rpc_error_maybe(
-        metrics: Arc<AuthAggMetrics>,
-        display_name: &String,
-        error: &IotaError,
-    ) {
+    fn record_rpc_error_maybe(metrics: Arc<AuthAggMetrics>, display_name: &str, error: &IotaError) {
         if let IotaError::Rpc(_message, code) = error {
             metrics
                 .total_rpc_err

crates/iota-core/src/authority_server.rs

@@ -819,8 +819,8 @@ impl ValidatorService {
         };
         let request = request.into_inner();
 
-        let certificates = NonEmpty::from_vec(request.certificates)
-            .ok_or_else(|| IotaError::NoCertificateProvided)?;
+        let certificates =
+            NonEmpty::from_vec(request.certificates).ok_or(IotaError::NoCertificateProvided)?;
         for certificate in &certificates {
             // We need to check this first because we haven't verified the cert signature.
             certificate.validity_check(epoch_store.protocol_config(), epoch_store.epoch())?;

crates/iota-core/src/safe_client.rs

@@ -372,9 +372,9 @@ where
 
             for object in input_objects {
                 let object_ref = object.compute_object_reference();
-                if !expected
+                if expected
                     .get(&object_ref.0)
-                    .is_some_and(|expect| &object_ref == expect)
+                    .is_none_or(|expect| &object_ref != expect)
                 {
                     return Err(IotaError::ByzantineAuthoritySuspicion {
                         authority: self.address,
@@ -395,9 +395,9 @@ where
 
             for object in output_objects {
                 let object_ref = object.compute_object_reference();
-                if !expected
+                if expected
                     .get(&object_ref.0)
-                    .is_some_and(|expect| &object_ref == expect)
+                    .is_none_or(|expect| &object_ref != expect)
                 {
                     return Err(IotaError::ByzantineAuthoritySuspicion {
                         authority: self.address,

crates/iota-graphql-rpc/src/types/cursor.rs

@@ -250,6 +250,7 @@ impl Page<JsonCursor<ConsistentIndexCursor>> {
     /// two booleans indicating whether there is a previous or next page in
     /// the range, the `checkpoint_viewed_at` to set for consistency, and an
     /// iterator of cursors within that Page.
+    #[allow(clippy::type_complexity)]
     pub(crate) fn paginate_consistent_indices(
         &self,
         total: usize,

crates/iota-types/src/effects/test_effects_builder.rs

@@ -55,7 +55,7 @@ impl TestEffectsBuilder {
     }
 
     pub fn build(self) -> TransactionEffects {
-        let status = self.status.unwrap_or_else(|| ExecutionStatus::Success);
+        let status = self.status.unwrap_or(ExecutionStatus::Success);
         // TODO: This does not yet support deleted shared objects.
         let shared_objects = self
             .shared_input_versions