Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always emit "Symbol Path: ", even when running --nolldb #488

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Always emit "Symbol Path: ", even when running --nolldb #488

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b04bfa
Always emit "Symbol Path: ", even when running `--nolldb`, as its inc…
dwarfland Nov 17, 2020
e7e56b3
Merge branch 'master' into master
dwarfland Nov 19, 2020
a075cab
Undid accidental space->tab changes, sorry about that.
dwarfland Nov 19, 2020
ac9441c
Always emit "Symbol Path:" (added to Json too)
dwarfland Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/ios-deploy/ios-deploy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,16 @@ void mount_developer_image(AMDeviceRef device) {

on_error(@"Unable to mount developer disk image. (%x)", result);
}


CFStringRef symbols_path = copy_device_support_path(device, CFSTR("Symbols"));
if (symbols_path != NULL)
{
NSLogOut(@"Symbol Path: %@", symbols_path);
NSLogJSON(@{@"Event": @"MountDeveloperImage",
@"SymbolsPath": (__bridge NSString *)symbols_path
}); CFRelease(symbols_path);
}

CFRelease(image_path);
CFRelease(options);
}
Expand Down