QARTOD Spike Test: alternative differential method #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwilcox
suggested changes
Mar 25, 2021
|
I pushed the corrections! Thanks for your feedbacks @kwilcox |
Align with attenuated_signal_test format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR present an implementation of the spike detection algorithm presented within the issue #48 .
This Pull Request essentially add an optional input method to the QARTOD spike test that and add an optional differential method for detecting spikes. If not specified, the standard method average method suggested by QARTOD is used.
A series of tests are also added to the test module to handle the different methods and the method input.