Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set some F#-specific parameters that are used in lieu of setting DOTNET_HOST_PATH #127

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

baronfel
Copy link
Collaborator

This is a promising approach, though if the props in the compiler change we might be broken.

@baronfel
Copy link
Collaborator Author

This might address @dsyme's concerns here

@baronfel baronfel merged commit 92d9768 into main Nov 17, 2021
@baronfel
Copy link
Collaborator Author

This is bad and we need better testing. The results that come out of cracking with just these parameters set are not useful:

FscCommandLineArgs
    -o:obj\Debug\net6.0\blah.dll
    -g
    --debug:portable
    --noframework
    --define:TRACE
    --define:DEBUG
    --define:NET
    --define:NET6_0
    --define:NETCOREAPP
    --define:NET5_0_OR_GREATER
    --define:NET6_0_OR_GREATER
    --define:NETCOREAPP1_0_OR_GREATER
    --define:NETCOREAPP1_1_OR_GREATER
    --define:NETCOREAPP2_0_OR_GREATER
    --define:NETCOREAPP2_1_OR_GREATER
    --define:NETCOREAPP2_2_OR_GREATER
    --define:NETCOREAPP3_0_OR_GREATER
    --define:NETCOREAPP3_1_OR_GREATER
    --optimize-
    --tailcalls-
    -r:C:\Users\chethusk\.nuget\packages\fsharp.core\6.0.1\lib\netstandard2.1\FSharp.Core.dll
    --target:exe
    --warn:3
    --warnon:3368,3369
    --warnaserror:3239
    --fullpaths
    --flaterrors
    --highentropyva+
    --targetprofile:netcore
    --nocopyfsharpcore
    --deterministic+
    --simpleresolution
    obj\Debug\net6.0\blah.AssemblyInfo.fs
    Program.fs

Note the absence of any of the SDK refs

@baronfel
Copy link
Collaborator Author

@dsyme we might need some real deep thinking about how/why the FCS APIs exactly work inconsistently when this is set.

@baronfel baronfel deleted the less-invasive-parameters branch November 18, 2021 16:03
Krzysztof-Cieslak added a commit that referenced this pull request Nov 19, 2021
Krzysztof-Cieslak added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant