Additional fixes and updates to various tools #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra sanity checks in check_submission_dir(): it now checks towards the beginning if the required files exist (that is, the three user submitted files, not the JSON file as those don't exist yet, though it does check that they do not exist as dot files here would be an error) and are readable and if they are not size 0 (for Makefile and remarks.md - prog.c may be empty). Updated some literal strings of the three required filenames (as above) to their macros in both mkiocccentry and txzchk. Fixes in chkentry with checking if files exist or do not exist (depending on options) and also add checks for file sizes for certain files, namely Makefile, remarks.md (in non-winning mode) as well as index.html (in winning mode) and README.md (in winning mode). Error messages were improved in chkentry as well though there are some places (the manifest check) where they could be improved (this would require lower level changes that we do not have time for before the freeze later today). Sync [jparse repo](https://github.com/xexyl/jparse/) to jparse/ for new util function (that uses its file_size() function) is_empty(). This is used in the update to chkentry. More work on the chkentry_test.sh script. The script is in better shape so that when the directories are generated (they cannot be static due to version changes - at least without a new option) the script should hopefully be easily updated (though it depends maybe on how the new directories are generated). Updated MKIOCCCENTRY_VERSION to "1.2.36 2025-02-28". Updated TXZCHK_VERSION to "1.1.15 2025-02-28". Updated CHKENTRY_VERSION to "1.1.6 2025-02-28". Updated CHKENTRY_TEST_VERSION to "1.1.1 2025-02-28".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra sanity checks in check_submission_dir(): it now checks towards the beginning if the required files exist (that is, the three user submitted files, not the JSON file as those don't exist yet, though it does check that they do not exist as dot files here would be an error) and are readable and if they are not size 0 (for Makefile and remarks.md - prog.c may be empty).
Updated some literal strings of the three required filenames (as above) to their macros in both mkiocccentry and txzchk.
Fixes in chkentry with checking if files exist or do not exist (depending on options) and also add checks for file sizes for certain files, namely Makefile, remarks.md (in non-winning mode) as well as index.html (in winning mode) and README.md (in winning mode).
Error messages were improved in chkentry as well though there are some places (the manifest check) where they could be improved (this would require lower level changes that we do not have time for before the freeze later today).
Sync jparse repo to jparse/ for new util function (that uses its file_size() function) is_empty(). This is used in the update to chkentry.
More work on the chkentry_test.sh script. The script is in better shape so that when the directories are generated (they cannot be static due to version changes - at least without a new option) the script should hopefully be easily updated (though it depends maybe on how the new directories are generated).
Updated MKIOCCCENTRY_VERSION to "1.2.36 2025-02-28". Updated TXZCHK_VERSION to "1.1.15 2025-02-28".
Updated CHKENTRY_VERSION to "1.1.6 2025-02-28".
Updated CHKENTRY_TEST_VERSION to "1.1.1 2025-02-28".