Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename topdir -> submission_dir in chkentry #1188

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Feb 26, 2025

The tool is run on the submission directory that has the files that came
from the topdir, not the topdir itself.

Updated MKIOCCCENTRY_VERSION to "1.2.34 2025-02-26".
The tool is run on the submission directory that has the files that came
from the topdir, not the topdir itself.
Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

@xexyl
Copy link
Contributor Author

xexyl commented Feb 26, 2025

Seems reasonable 👍

I thought so too. It is amusing it only dawned on me today but at least it's fixed now. It could be confusing to some otherwise.

Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

Does anything in "the other repo", such that the FAQ, need to change in a similar way, @xexyl ?

@lcn2 lcn2 merged commit 4c766c2 into ioccc-src:master Feb 26, 2025
3 checks passed
@xexyl
Copy link
Contributor Author

xexyl commented Feb 26, 2025

Good idea 👍

Does anything in "the other repo", such that the FAQ, need to change in a similar way, @xexyl ?

I was actually working on that when I thought I noticed something missing (a check) which made me see this. So in answer to the question - yes. Working on it and in general going through stuff about chkentry for the recent changes.

I might also wish to do so for mkiocccentry though I did do some of that a while back. Still I might have made further updates (I know I did in the lower level stuff but not sure on the higher level).

@xexyl
Copy link
Contributor Author

xexyl commented Feb 26, 2025

Just synced the updated html files to the server .. will check them and if all good I'll commit. I'm unsure if I can do a thorough check today but if not I will tomorrow. I'm having a hard time seeing now and I'll probably be leaving soon as well.

@xexyl xexyl deleted the sub branch February 26, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants