WIP: Django5 #1384
Open
WIP: Django5 #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop python 3.9 support, as django 5.2 does not support it anymore
commit should be dropped for production and recreated with only released versions For generate_requirments `--pre` was added as a command line argument.
seems like the lib needs to be adapted. Ideally, drop this commit. Error was ``` ERROR: setUpClass (tests.apps.ikhaya.test_migrations.TestArticalePublicationMerge) ---------------------------------------------------------------------- TypeError: MigratorTestCase._pre_setup() missing 1 required positional argument: 'self' ====================================================================== ERROR: setUpClass (tests.apps.portal.test_migrations.TestEventDateTimeMerge) ---------------------------------------------------------------------- TypeError: MigratorTestCase._pre_setup() missing 1 required positional argument: 'self' ====================================================================== ERROR: setUpClass (tests.apps.portal.test_migrations.TestUserJabberContentMigration) ---------------------------------------------------------------------- TypeError: MigratorTestCase._pre_setup() missing 1 required positional argument: 'self' ====================================================================== ERROR: setUpClass (tests.apps.portal.test_migrations.TestUserJabberFieldMigration) ---------------------------------------------------------------------- TypeError: MigratorTestCase._pre_setup() missing 1 required positional argument: 'self' ====================================================================== ERROR: setUpClass (tests.apps.portal.test_migrations.TestUserSha1PasswordRemoval) ---------------------------------------------------------------------- TypeError: MigratorTestCase._pre_setup() missing 1 required positional argument: 'self' ```
``` pyupgrade --py310-plus --keep-percent-format ```
a not implemented `Given` was used. Error was ``` You can implement step definitions for undefined steps with these snippets: from behave.api.pending_step import StepNotImplementedError @given(u'the user "blog_user" exits') def step_impl(context): raise StepNotImplementedError(u'STEP: Given the user "blog_user" exits') Errored scenarios: tests/bdd/planet/blog.feature:67 URL-Fields should be validated -- @1.1 tests/bdd/planet/blog.feature:68 URL-Fields should be validated -- @1.2 tests/bdd/planet/blog.feature:69 URL-Fields should be validated -- @1.3 tests/bdd/planet/blog.feature:70 URL-Fields should be validated -- @1.4 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to see if the CI runs with the alpha of Django 5.2. (and that work is not done twice)