Reorganize TravisCI build config to fix cross-platform builds #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invisiblethreat
approved these changes
Oct 9, 2018
|
Many thanks @theag3nt! This is my only project using TravisCI, so the helping hand here really will make things easier in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in #4 was caused by the platform-specific dependencies of logrus.
This could've been solved by simply adding an extra
go getfor the missing dependency (see sirupsen/logrus#824), but as I was already editing the Travis build config, I reorganized it to delegate more steps to the build matrix and pull the correct dependencies for each platform.The result should be a bit more future proof builds for the project.
Fixes #3 and fixes #4.