file_links: prepare for changes in invenio-records-resources [+] #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invenio-records-resources will not provide default `file_links_{item,search}`
values, because with the usage of `invenio_url_for` those default values cannot
be generic anymore. Links need a specific endpoint which the default config
cannot provide (doesn't provide a blueprint for starters). So to prevent
breakage when invenio-records-resources is released and invenio-rdm-records
uses it before its own code has been changed, we need to make the pre-emptive
change in this PR.
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invenio-records-resources will not provide default
file_links_{item,search}values anymore, because with the usage of
invenio_url_forthose default values cannotbe generic. Links need a specific endpoint which the default config
cannot provide (doesn't provide a blueprint for starters). So to prevent
breakage when invenio-records-resources is released and invenio-rdm-records
uses it before its own code has been changed, we need to make the pre-emptive
change in this PR.