-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-plugin-vue-i18n): use correct id in hmr #160
Conversation
@ghostiam’s comment: #153 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Welcome contribution!
LGTM!
@@ -210,7 +210,9 @@ function pluginI18n( | |||
async handleHotUpdate({ file, server }) { | |||
if (/\.(json5?|ya?ml)$/.test(file)) { | |||
const module = server.moduleGraph.getModuleById( | |||
INTLIFY_BUNDLE_IMPORT_ID | |||
getVirtualId( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... I forgot that virtual id has been used in the plugin 😅
@marekvospel |
@kazupon this currently fails building. I would suggest you add a build stage to GitHub Actions (I’m happy to do so with a PR)
|
I've fixed the lint problem & changed to the correct method, so build should pass |
@marekvospel |
fixes #153
I haven't tested this, as I currently don't have access to my computer, nor github codespaces.