Add UUID db columns #873
Merged
Add UUID db columns #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artur-intech
commented
Jun 12, 2018
•
artur-intech
commented
- Needed for REST API v2 (GDPR - Registrant: Enable user to update contact data of their domain contacts #849)
- Test domain/contact adding/editing, contact/domain transfer
- REST API v1 will probably start returning UUIDs as well, since there is no filter on API side (it just returns all values straight from a DB). Don't think it might be a problem
It will be generated on DB level
| @@ -16,6 +16,7 @@ def transfer(new_registrar) | |||
| new_contact.regenerate_code | |||
| new_contact.regenerate_auth_info | |||
| new_contact.remove_address unless self.class.address_processing? | |||
| new_contact.uuid = nil | |||
There was a problem hiding this comment.
Why is this required? Is there a reason why UUIDs cannot stay the same after a transfer, like primary keys?
There was a problem hiding this comment.
Because transfer operation effectively creates a new copy of a contact, based on the original one. What primary key remains the same?
There was a problem hiding this comment.
Why then pkey stays the same, instead of also being regenerated?
There was a problem hiding this comment.
Primary key is unique by definition. Where do you see that it remains the same?
There was a problem hiding this comment.
Folding issues, didn't see the self.dup at the beginning. All good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.