Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve registrant change mailer #1149

Merged
merged 5 commits into from
Apr 9, 2019
Merged

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Apr 5, 2019

  • DRY templates
  • Add preview

Verify emails' content (signature & confirmation link parts) and sending of confirmation email.

@artur-intech artur-intech force-pushed the improve-registrant-change-mailer branch 3 times, most recently from db145ae to c73798d Compare April 6, 2019 12:06
@artur-intech artur-intech force-pushed the improve-registrant-change-mailer branch from c73798d to d25c9b4 Compare April 6, 2019 13:31
@vohmar
Copy link
Contributor

vohmar commented Apr 9, 2019

emails are sent and content is almost the same as it was, small changes in spacing.
Incorrect url is still there in the staging emails, but the problem was there before

@vohmar vohmar merged commit c192cc0 into master Apr 9, 2019
@artur-intech
Copy link
Contributor Author

artur-intech commented Apr 9, 2019

URL problem you mentioned is addressed by #1151.

Spacing issues will be fixed a bit later.

@vohmar vohmar deleted the improve-registrant-change-mailer branch April 30, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants