Handle IDN domain names in EPP check and EPP create #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2019 17:17
Both ASCII and unicode should be supported to register a domain.
artur-intech
reviewed
Apr 2, 2019
| Domain.release_to_auction = false | ||
| end | ||
|
|
||
| def test_registers_domain_with_ascii_idn_cannot_be_registered_without_registration_code |
There was a problem hiding this comment.
I don't understand this. Forgot to delete registers?
There was a problem hiding this comment.
Copy and paste error
|
blocked domain still affected, fix works for reserved and auctioned domains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in auction integration, but also affects existing reserved and blocked domains.