Change invoices.issue_date database column to NOT NULL

[artur-intech]

• Deploy only once populate_invoice_issue_date data migration is run against every deployment, since this change removes it!
• Cannot be released along with Refactor and improve invoices #1013.

Closes #1008

[vohmar]

deployment failed on staging due to null issue_date values. All the issue_date columen values are empty for that matter so apparently populate_invoice_issue_date was not run

       rake aborted!
       StandardError: An error has occurred, this and all later migrations canceled:

       PG::NotNullViolation: ERROR:  column "issue_date" contains null values
       : ALTER TABLE "invoices" ALTER "issue_date" SET NOT NULL

[artur-intech]

Then run it, what's the problem?

[vohmar]

I cannot as db is replaced with every deployment so this migration should be run in the deployment process prior to removing it

[artur-intech]

Then talk to @ratM1n to switch to fixtures (test data we use for testing). I briefly explained him a point of them.

I could assist further, if you are OK to migrate.

https://guides.rubyonrails.org/testing.html#the-low-down-on-fixtures

P.S. I wonder how #1013 was tested if you say it's impossible to run that data migration.

[vohmar]

not able to deploy

[artur-intech]

How can I help?

[artur-intech]

@ratM1n Confirmed it's now in working state.