Rename fixture, remove defaults

test/fixtures/account_activities.yml

@@ -1,5 +1,5 @@
 one:
   account: cash
-  invoice: valid
+  invoice: one
   bank_transaction: one
   created_at: <%= Time.zone.parse('2010-07-05 10:00') %>

test/fixtures/invoice_items.yml

@@ -3,4 +3,4 @@ one:
   price: 5
   quantity: 1
   unit: pc
-  invoice: valid
+  invoice: one

test/fixtures/invoices.yml

@@ -1,4 +1,4 @@
-DEFAULTS: &DEFAULTS
+one:
   issue_date: <%= Date.parse '2010-07-05' %>
   due_date: <%= Date.parse '2010-07-06' %>
   currency: EUR
@@ -10,10 +10,15 @@ DEFAULTS: &DEFAULTS
   total: 16.50
   reference_no: 13
 
-valid:
-  <<: *DEFAULTS
-
 for_payments_test:
-  <<: *DEFAULTS
-  total: 12.00
   number: 1
+  issue_date: <%= Date.parse '2010-07-05' %>
+  due_date: <%= Date.parse '2010-07-06' %>
+  currency: EUR
+  seller_name: John Doe
+  seller_iban: 1234
+  buyer: bestnames
+  buyer_name: Jane Doe
+  vat_rate: 0.1
+  reference_no: 13
+  total: 12.00

test/models/bank_transaction_test.rb

@@ -2,7 +2,7 @@
 
 class BankTransactionTest < ActiveSupport::TestCase
   def test_matches_against_invoice_reference_number
-    invoices(:valid).update!(account_activity: nil, number: '2222', total: 10, reference_no: '1111')
+    invoices(:one).update!(account_activity: nil, number: '2222', total: 10, reference_no: '1111')
     transaction = BankTransaction.new(description: 'invoice #2222', sum: 10, reference_no: '1111')
 
     assert_difference 'AccountActivity.count' do
@@ -20,7 +20,7 @@ def test_does_not_match_against_registrar_reference_number
   end
 
   def test_underpayment_is_not_matched_with_invoice
-    invoices(:valid).update!(account_activity: nil, number: '2222', total: 10)
+    invoices(:one).update!(account_activity: nil, number: '2222', total: 10)
     transaction = BankTransaction.new(sum: 9)
 
     assert_no_difference 'AccountActivity.count' do
@@ -30,7 +30,7 @@ def test_underpayment_is_not_matched_with_invoice
   end
 
   def test_overpayment_is_not_matched_with_invoice
-    invoices(:valid).update!(account_activity: nil, number: '2222', total: 10)
+    invoices(:one).update!(account_activity: nil, number: '2222', total: 10)
     transaction = BankTransaction.new(sum: 11)
 
     assert_no_difference 'AccountActivity.count' do
@@ -40,7 +40,7 @@ def test_overpayment_is_not_matched_with_invoice
   end
 
   def test_cancelled_invoice_is_not_matched
-    invoices(:valid).update!(account_activity: nil, number: '2222', total: 10, cancelled_at: '2010-07-05')
+    invoices(:one).update!(account_activity: nil, number: '2222', total: 10, cancelled_at: '2010-07-05')
     transaction = BankTransaction.new(sum: 10)
 
     assert_no_difference 'AccountActivity.count' do

test/models/invoice/cancellable_test.rb

@@ -2,7 +2,7 @@
 
 class CancellableInvoiceTest < ActiveSupport::TestCase
   setup do
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
   end
 
   def test_non_cancelled_scope_returns_non_cancelled_invoices

test/models/invoice/payable_test.rb

@@ -2,7 +2,7 @@
 
 class InvoiceTest < ActiveSupport::TestCase
   setup do
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
   end
 
   def test_unpaid_scope_returns_unpaid_invoices

test/models/invoice_test.rb

@@ -2,7 +2,7 @@
 
 class InvoiceTest < ActiveSupport::TestCase
   setup do
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
   end
 
   def test_fixture_is_valid

test/services/overdue_invoice_canceller_test.rb

@@ -2,7 +2,7 @@
 
 class OverdueInvoiceCancellerTest < ActiveSupport::TestCase
   setup do
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
   end
 
   def test_default_delay

test/system/admin_area/invoices_test.rb

@@ -3,7 +3,7 @@
 class AdminAreaInvoicesTest < ApplicationSystemTestCase
   setup do
     sign_in users(:admin)
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
   end
 
   def test_cancels_an_invoice

test/system/registrar_area/invoices/list_test.rb

@@ -5,7 +5,7 @@ class ListInvoicesTest < ApplicationSystemTestCase
     @user = users(:api_bestnames)
     sign_in @user
 
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
     eliminate_effect_of_other_invoices
   end
 

test/system/registrar_area/invoices_test.rb

@@ -3,7 +3,7 @@
 class RegistrarAreaInvoicesTest < ApplicationSystemTestCase
   setup do
     sign_in users(:api_bestnames)
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
   end
 
   def test_cancels_an_invoice

test/tasks/data_migrations/populate_invoice_issue_date_test.rb

@@ -2,7 +2,7 @@
 
 class PopulateInvoiceIssueDateTaskTest < ActiveSupport::TestCase
   setup do
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
   end
 
   def test_populates_invoice_issue_date

test/tasks/invoices/cancel_overdue_test.rb

@@ -2,7 +2,7 @@
 
 class CancelOverdueInvoicesTaskTest < ActiveSupport::TestCase
   setup do
-    @invoice = invoices(:valid)
+    @invoice = invoices(:one)
     eliminate_effect_of_other_invoices
   end