Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should I do if I face a 404 page error on local / on openlibrary.org site ? #1864

Closed
supercontracts opened this issue Feb 6, 2019 · 7 comments

Comments

@supercontracts
Copy link
Collaborator

supercontracts commented Feb 6, 2019

Description

What problem are we solving? What does the experience look like today? What are the symptoms?
Here is the problem of landing on a 404 page error
e1

@supercontracts supercontracts changed the title What should I do if I face a 404 error on local / openlibrary main site What should I do if I face a 404 page error on local / openlibrary main site Feb 6, 2019
@supercontracts supercontracts changed the title What should I do if I face a 404 page error on local / openlibrary main site What should I do if I face a 404 page error on local / openlibrary main site ? Feb 6, 2019
@supercontracts supercontracts changed the title What should I do if I face a 404 page error on local / openlibrary main site ? What should I do if I face a 404 page error on local / on openlibrary.org site ? Feb 6, 2019
@hornc
Copy link
Collaborator

hornc commented Feb 7, 2019

404s are just page / resource not found messages, meaning the server cannot find anything that matches whatever URL you requested, it's a perfectly acceptable and informative response code. It could be a bigger problem if a page that really should exist gives a 404, but that depends on the URL.

https://openlibrary.org/soijfsofwegfewungsdmfsd should always give a 404, and that is not a problem, the 404 is actually a good, informative, thing.

Adding debug=true to the end of a 404ing URL won't give any extra information unfortunately -- the page was simply not found. Nothing went wrong as far as the server was concerned, so it has no more details to give.

debug=true is useful when a server error occurs, which is a different kind of error. 5xx HTTP response codes and possibly other errors that are caught and result in 'this error has been logged' messages on the resulting page.

We could perhaps put more info on our 404 pages to make that clearer, or go for something cute like most big sites:
https://github.com/404.html (yes, githhub, this is exactly the page I was looking for!)
https://www.docker.com/404.html Docker has always had interesting 404s
https://www.amazon.com/404.html shows different Amazon dogs...

@supercontracts
Copy link
Collaborator Author

@hornc Thanks for your detailed answer :)

@mekarpeles
Copy link
Member

@liaozhuzhu
Copy link

liaozhuzhu commented Jan 4, 2024

Came here from the FAQs where the title is marked: "Why do I hit a 404-page on local when the page shows up on openlibrary.org site?" which is exactly the issue I have right now; however, is not what this issue #1864 is addressing? I may be completely wrong, but based off the title of this issue, OP seemed to get a 404 on both local and on openlibrary.org.

After following all the guides of setting up docker, setting up frontend, adding test data, etc. I not only still can't see any books on dev, but also links to /about, /subjects, etc. (essentially any of the nav links) go to 404 even though https://openlibrary.org is just fine. The exception is "/trending/now" though again no books are shown. I've attached some images of what I see. I wanted to ask in the slack since it could possibly be my machine (M1 macOS), but I know the slack is on an invite only basis.

No books / sections rendered (could possibly be related)
Screen Shot 2024-01-04 at 3 55 20 AM

localhost:8080/subjects
Screen Shot 2024-01-04 at 3 57 04 AM

openlibrary.org/subjects:
Screen Shot 2024-01-04 at 3 57 45 AM

Thank you

@scottbarnes
Copy link
Collaborator

@liaozhuzhu, I think things are actually working normally for you. If you click on "Science Fiction" on the main page you should see a book called 'Flatland', though the cover may not appear properly: http://localhost:8080/works/OL118420W/Flatland.

With respect to the broken links for /about and the like, I think that is because they are pages on a wiki rather than being html pages generated from a template. The wiki-backed pages aren't present in the local development environment.

@liaozhuzhu
Copy link

@scottbarnes ah got it. Thank you so much for the reassurance. I was worried because the video attached under installation showed almost no difference from prod for the hosts machine. Are the exact differences from dev and prod noted somewhere in the repo and maybe I missed it?

@scottbarnes
Copy link
Collaborator

Are the exact differences from dev and prod noted somewhere in the repo and maybe I missed it?

I don't think think there is such a list, but this is a good idea. I created #8687 to reflect this. Thanks, @liaozhuzhu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants