Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher's "publishing history" graph shows other publishers' editions #158

Open
bencomp opened this issue Dec 30, 2012 · 8 comments
Open

Publisher's "publishing history" graph shows other publishers' editions #158

bencomp opened this issue Dec 30, 2012 · 8 comments
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@bencomp
Copy link
Contributor

bencomp commented Dec 30, 2012

Whereas the rationale for the graph labeled Publishing History is "This graph charts editions from this publisher over time", it appears that it also charts editions from other publishers who published other editions of the works that are in the first publisher's catalogue.

In pseudocode:
Let P1 be the publisher under study, who published edition E1 of work W1. Other editions of W1 are E2, E3 and E4, published by P2, P3 and P4 respectively. The graph then charts not only E1 (as per the description), but also E2, E3 and E4.
@anandology
Copy link
Collaborator

Known issue. We had to do it this way because we didn't had a editions solr to get the editions data.

@LeadSongDog
Copy link

LeadSongDog commented Mar 29, 2017 •
edited
Loading

Bump. Example: The chart at https://openlibrary.org/publishers/Thomas_Hailes_Lacy shows issues dating back to the 1597 edition publication of MacBeth, which clearly predates Lacy's birth in 1809. If it can't be fixed, there should at least be a disclaimer to avoid confusing users.

@jdlrobson jdlrobson added the Type: Bug Something isn't working. [managed] label Dec 15, 2018
@xayhewalo xayhewalo added Affects: UI Issues with the web site's user interface. [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged labels Nov 4, 2019
@xayhewalo
Copy link
Collaborator

Still a bug. @tfmorris I'm assuming we have an editions Solr to implement the algorithm in the original issue? I'm assuming either you or jdlrobson would head this.

@tfmorris
Copy link
Contributor

Yes, a proper fix is dependent on indexing editions (and would probably be fixed automatically with no additional work). If someone wanted to improve things in the mean time, they could implement the Mar 2017 suggestion.

@xayhewalo xayhewalo added Good First Issue Easy issue. Good for newcomers. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Nov 12, 2019
@xayhewalo
Copy link
Collaborator

xayhewalo commented Nov 12, 2019 •
edited
Loading

The patch until editions are indexed (with #2246 most likely) should be to display a disclaimer to the user so they're not confused. Assigning jdlrobson (not tagging as request) per slack discussions.

@jdlrobson jdlrobson removed their assignment Nov 14, 2019
@jdlrobson
Copy link
Collaborator

jdlrobson commented Nov 14, 2019 •
edited
Loading

Not a frontend issue. The frontend just renders the data passed by the backend and that's what needs to be fixed here.

We should just remove the graph if that's not easy (also a backend change)

@jdlrobson jdlrobson removed the Affects: UI Issues with the web site's user interface. [managed] label Nov 14, 2019
@xayhewalo xayhewalo added the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Nov 14, 2019
@mekarpeles mekarpeles removed the Good First Issue Easy issue. Good for newcomers. [managed] label Dec 12, 2019
@mekarpeles
Copy link
Member

This comment #158 (comment) suggests this is rather hard and blocked.

@mekarpeles mekarpeles added State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Dec 12, 2019
@xayhewalo xayhewalo added Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] and removed State: Backlogged labels Dec 24, 2019
@xayhewalo xayhewalo mentioned this issue Feb 21, 2020
Closed
@bicolino34 bicolino34 mentioned this issue Apr 19, 2023
Open
@tfmorris
Copy link
Contributor

@mekarpeles Now that editions are being indexed in Solr, this should no longer be blocked

@hornc hornc removed the Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] label Sep 10, 2023
@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@anandology @tfmorris @jdlrobson @hornc @mekarpeles @bencomp @xayhewalo @LeadSongDog