Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ChaptersPlugin to BookReaderPlugin #1381

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cdrini
Copy link
Contributor

@cdrini cdrini commented Feb 20, 2025

Blocked by #1380

@cdrini cdrini added the blocked label Feb 20, 2025
@cdrini cdrini force-pushed the refactor/chapters-br-plugin branch from 2aea201 to 349ef79 Compare February 20, 2025 05:43
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 44.59459% with 41 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (103935c) to head (2f181b8).

Files with missing lines Patch % Lines
src/plugins/plugin.chapters.js 44.44% 39 Missing and 1 partial ⚠️
src/BookReader.js 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
- Coverage   69.22%   69.20%   -0.02%     
==========================================
  Files          60       60              
  Lines        5150     5150              
  Branches     1103     1104       +1     
==========================================
- Hits         3565     3564       -1     
  Misses       1555     1555              
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini force-pushed the refactor/chapters-br-plugin branch from 349ef79 to 2f181b8 Compare February 20, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant