Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the application I'm working on, we check all of our endpoints against OpenApi schemas, and we take a big performance hit.
For instance one of our file performs 102 examples against a very simple controller, and right now here's the output of ruby prof for this test file:
With the changes in this PR:
I tried to be safe and cache the the schema based on both the file contents and the parser options, let me know if there's anything else I could have missed.
By the way I'm realizing that most of the class methods in
Committee::Drivers
should actually be private in the first place, but I decided not to include extra changes in this PR