-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strict response validation #319
Conversation
3a11378
to
a5b5fef
Compare
Hey @ota42y, what is missing to merge this PR? I would be glad to help. |
Sorry, there's nothing problem with this PR. Since 5.0.0 is a major version upgrade, we would like to include several breaking changes. committee use openapi_parser gem for validating OpenAPI 3 and I would like to release a major version upgrade (1.0.0) as the same time. So we should do these step
In openapi_parser 1.0.0, drop old ruby version. But it's taking too long..., and it's not a functional addition, I think I'll release to using more |
Regarding the Besides bumping Ruby to 3, is there any other breaking change you plan to introduce to the Thanks for the detailed explanation :) |
My concern was that changing the defined form later would have to be treated as a breaking changes (and we need to update major version). |
That makes sense. Let me know if there is anything I could help with, ok? |
a5b5fef
to
adc7d9a
Compare
sorry, master branch's version changed 5.0.0, so I merge this PR |
I released 5.0.0 with this changes! |
This changes break backward compatibility because when the user set strict option, old version is ignore but this version doesn't ignore.
So we should add warning on old version.
close: #317