This repository was archived by the owner on Nov 8, 2022. It is now read-only.
Go 1.7.6 #700
Merged
Go 1.7.6 #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run integration tests |
1 similar comment
|
run integration tests |
skonefal
suggested changes
May 24, 2017
|
run integration tests |
skonefal
reviewed
May 25, 2017
| @@ -4,7 +4,7 @@ services: | |||
| language: go | |||
| sudo: required | |||
| go: | |||
| - 1.7 | |||
| - 1.7.x | |||
There was a problem hiding this comment.
Is it OK for you to have different version of golang in Travis and in Integration Tests?
We should rather have the same version everywhere, so we should pick just one from:
a) Latest minor wildcard
b) Specific version
Currently, we have both :(
There was a problem hiding this comment.
@skonefal - I assume that we should be running latest version from chosen branch anyway and this approach allows to do so. If we were to add similar automation to vagrant provisioning then we would have to code it or use gimme as Travis does.
Side note: 1.7.6 was not available on Travis last night.
|
run integration tests |
skonefal
approved these changes
May 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue of using insecure Go version.
Summary of changes:
Testing done: