This repository was archived by the owner on Nov 8, 2022. It is now read-only.
Clean left pods on kubernetes cluster startup #675
Merged
+303
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpatelcz
force-pushed
the
mpatelcz/k8s_cleanup_leftovers
branch
from
3a7af99 to
4426f60
Compare
mpatelcz
force-pushed
the
mpatelcz/k8s_cleanup_leftovers
branch
5 times, most recently
from
d1b6560 to
ec593a8
Compare
mpatelcz
force-pushed
the
mpatelcz/k8s_cleanup_leftovers
branch
from
ec593a8 to
01b410b
Compare
|
run integration tests |
3 similar comments
|
run integration tests |
|
run integration tests |
|
run integration tests |
mpatelcz
force-pushed
the
mpatelcz/k8s_cleanup_leftovers
branch
from
01b410b to
d360694
Compare
|
run integration tests |
Name and description of the flag was changed so that it reflects its purpose. Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
Implemented test checking if removing unwanted pods in k8s works. Reworked the code responsible for the removal of the pods. Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
mpatelcz
force-pushed
the
mpatelcz/k8s_cleanup_leftovers
branch
from
d360694 to
1b47aa4
Compare
|
run integration tests |
ppalucki
approved these changes
May 26, 2017
pkg/kubernetes/kubernetes.go
Outdated
| }, | ||
| ) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
I think we need wrap an error here - just panic can looks ugly
ppalucki
approved these changes
May 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After dirty shutdown some of the pods may still be in the registry and creation of them caused errors.
Adding flag which will allow to clear cluster on startup so that creation of pods is guaranteed.