This repository was archived by the owner on Nov 8, 2022. It is now read-only.
Getting rid of centos_swan_image #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run integration tests |
skonefal
reviewed
May 10, 2017
vagrant/provision_ci_environment.sh
Outdated
|
|
||
| echo "Install binaries from /opt/swan" | ||
| ln -sv ${SWAN_BIN}/* /bin/ | ||
| echo "Install binaries to /opt/swan and symlink them to /bin" |
There was a problem hiding this comment.
FYI: in #656 this is part of provision_exp_environment.
skonefal
approved these changes
May 10, 2017
iwankgb
force-pushed
the
iwan/SCE-1156_using_public_docker_image
branch
2 times, most recently
from
ec3e738 to
ecc981c
Compare
|
run integration tests |
mpatelcz
approved these changes
May 10, 2017
skonefal
approved these changes
May 10, 2017
|
@iwankgb kill docs/install.md |
iwankgb
force-pushed
the
iwan/SCE-1156_using_public_docker_image
branch
from
ecc981c to
4c620dd
Compare
|
run integration tests |
skonefal
suggested changes
May 11, 2017
| @@ -141,6 +141,14 @@ wget --no-verbose https://github.com/intelsdi-x/snap-plugin-publisher-file/relea | |||
| wget --no-verbose https://github.com/intelsdi-x/snap-plugin-collector-use/releases/download/${SNAP_PLUGIN_COLLECTOR_USE_VERSION}/snap-plugin-collector-use_linux_x86_64 -O ${SWAN_BIN}/snap-plugin-collector-use | |||
|
|
|||
|
|
|||
| echo "----------------------------- Pulling docker image (`date`)" | |||
| docker pull intelsdi/swan | |||
There was a problem hiding this comment.
Both of 'docker pull' and 'retrieve binaries' are already in line 103. Please remove.
iwankgb
force-pushed
the
iwan/SCE-1156_using_public_docker_image
branch
2 times, most recently
from
6905183 to
5855a7e
Compare
|
run integration tests |
skonefal
approved these changes
May 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue SCE-1156
Summary of changes:
centos_swan_imageTesting done: