Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYCL device compiler optimizations impact #2264

Closed
bader opened this issue Aug 5, 2020 · 1 comment
Closed

SYCL device compiler optimizations impact #2264

bader opened this issue Aug 5, 2020 · 1 comment
Assignees
@bader @Fznamznon
Labels
blocker Blocks important functionality bug Something isn't working help wanted We don't have ability to look into this at the moment, but contributions are welcome

Comments

@bader
Copy link
Contributor

bader commented Aug 5, 2020 •
edited
Loading

Following tests are failing if SYCL device compiler optimizes LLVM IR for SPIR target before translation to SPIR-V format:

Open

  1. sycl/test/basic_tests/boolean.cpp

Resolved

  1. sycl/test/fpga_tests/fpga_lsu.cpp - fixed [SYCL][NFC] Remove workaround for SPIR-V translator issues #2369
  2. sycl/test/basic_tests/accessor/accessor.cpp - fixed by [SYCL] Enable early optimizations for 2 LIT tests #2444
  3. sycl/test/regression/group.cpp - fixed [SYCL] Enable early optimizations for 2 LIT tests #2444
  4. sycl/test/spec_const/spec_const_hw.cpp - fixed by [SYCL] Enable early optimizations for spec_const LIT test #2448
  5. sycl/test/sub_group/generic-shuffle.cpp - [SYCL][NFC] Remove workaround for SPIR-V translator issues #2450
  6. sycl/test/sub_group/scan_fp16.cpp - [SYCL][NFC] Remove workaround for SPIR-V translator issues #2450
  7. sycl/test/sub_group/shuffle.cpp - [SYCL][NFC] Remove workaround for SPIR-V translator issues #2450
  8. sycl/test/sub_group/shuffle_fp16.cpp - [SYCL][NFC] Remove workaround for SPIR-V translator issues #2450
  9. sycl/test/sub_group/shuffle_fp64.cpp - [SYCL][NFC] Remove workaround for SPIR-V translator issues #2450
  10. sycl/test/basic_tests/stream/stream.cpp - [SYCL CI][Linux GPU RT Uplift] Uplift GPU RT version for Linux CI Process #2504 and [SYCL][Deps]Uplift Windows GPU RT from 8673 to 8778 #2533
  11. sycl/test/hier_par/hier_par_wgscope.cpp - [SYCL CI][Linux GPU RT Uplift] Uplift GPU RT version for Linux CI Process #2504 and [SYCL][Deps]Uplift Windows GPU RT from 8673 to 8778 #2533
  12. sycl/test/sub_group/generic_reduce.cpp - [SYCL CI][Linux GPU RT Uplift] Uplift GPU RT version for Linux CI Process #2504 and [SYCL][Deps]Uplift Windows GPU RT from 8673 to 8778 #2533
  13. sycl/test/sub_group/load_store.cpp - [SYCL CI][Linux GPU RT Uplift] Uplift GPU RT version for Linux CI Process #2504 and [SYCL][Deps]Uplift Windows GPU RT from 8673 to 8778 #2533

This issue is exposed by #2207.
@bader bader added bug Something isn't working help wanted We don't have ability to look into this at the moment, but contributions are welcome blocker Blocks important functionality labels Aug 5, 2020
@bader bader self-assigned this Aug 5, 2020
@Fznamznon Fznamznon self-assigned this Aug 14, 2020
@bader bader mentioned this issue Sep 10, 2020
Merged
@bader
Copy link
Contributor Author

bader commented Apr 26, 2021

#2458 fixes failure of sycl/test/basic_tests/boolean.cpp.

@bader bader closed this as completed Jun 12, 2021
jsji pushed a commit that referenced this issue Dec 21, 2023
@bwlodarcz @sys-ce-bb
Access out of scope fix in OCLToSPIRVBase::visitCallAtomicCmpXchg (#2264
70ec903 
)

Pointer named Expected was taken by reference to closure to be executed
later by Mutator. Mutator executes the closure in his destructor
which happens after the destruction of Expected pointer stack frame.
This fix clears some ASan errors from #2233.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@c7cd904
Chenyang-L pushed a commit that referenced this issue Feb 18, 2025
@callumfare
Merge pull request #2264 from Bensuo/ben/cmdbuf-local-arg-fix
49a39e4 
[CMDBUF] Fix incorrect handling of shared local mem args in CUDA/HIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bader bader

@Fznamznon Fznamznon

Labels
blocker Blocks important functionality bug Something isn't working help wanted We don't have ability to look into this at the moment, but contributions are welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bader @Fznamznon