Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CppUTest: remove unused stub function in TestRegistry test #86

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

pcolberg
Copy link
Contributor

@pcolberg pcolberg commented Feb 23, 2022

This is aligned with the current upstream version of this file:

https://github.com/cpputest/cpputest/blob/a1913dec36d277fd3d169a323b7c0d2b11950c43/tests/CppUTest/TestRegistryTest.cpp#L33-L36

[61/113] Building CXX object lib/CppUTest/test/CMakeFiles/CppUTestTests.dir/TestRegistryTest.cpp.o
../lib/CppUTest/test/TestRegistryTest.cpp:34:6: warning: ‘void {anonymous}::stub()’ defined but not used [-Wunused-function]
 void stub()
      ^~~~

Prerequisite of #85

This is aligned with the current upstream version of this file:

https://github.com/cpputest/cpputest/blob/a1913dec36d277fd3d169a323b7c0d2b11950c43/tests/CppUTest/TestRegistryTest.cpp#L33-L36

[61/113] Building CXX object lib/CppUTest/test/CMakeFiles/CppUTestTests.dir/TestRegistryTest.cpp.o
../lib/CppUTest/test/TestRegistryTest.cpp:34:6: warning: ‘void {anonymous}::stub()’ defined but not used [-Wunused-function]
 void stub()
      ^~~~
@pcolberg pcolberg self-assigned this Feb 23, 2022
@pcolberg pcolberg requested a review from zibaiwan February 23, 2022 23:52
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Peter!

@pcolberg pcolberg merged commit 2f00495 into intel:main Feb 24, 2022
@pcolberg pcolberg deleted the cpputest-unused-stub-function branch February 24, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants