Add documentation for how OpenCL runtime manages buffers #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherry-yuan
force-pushed
the
doc_buffer
branch
from
1d3aab2 to
c4b9b69
Compare
sherry-yuan
force-pushed
the
doc_buffer
branch
from
c4b9b69 to
0a4e84c
Compare
aditikum
reviewed
Mar 14, 2022
aditikum
previously approved these changes
Mar 14, 2022
|
@aditikum - Thanks for the approval! The approval are dismissed after new commits, you may need to re-approve. @vijethamalkai @pcolberg @zibaiwan @huangbri - Does this seem ok to you? |
zibaiwan
previously approved these changes
Mar 14, 2022
There was a problem hiding this comment.
@sherry-yuan , sorry for the late appoval. Your documentation looks great to me. Thanks for adding this. It's very helpful for runtime development.
|
Thanks @vijethamalkai for the revision and suggestions! The latest commit 0879ed8 address Vij's suggestion on the use of ambiguous 'it' 'this' 'that' etc. |
pcolberg
requested changes
Mar 15, 2022
There was a problem hiding this comment.
Thanks @sherry-yuan for the great work, and thanks @vijethamalkai for the corrections 🙂
--------------------------------------------------------------------------- It specifically documents; 1. how it is used 2. how sycl use it 3. some caveats 4. how memory are allocated 5. device address encoding 6. the whole implementation flow of all function that are responsible for allocation, memory transfer 7. some corner cases
pcolberg
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It specifically documents;
Closes #78