Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread sanitizer option to cmake #76

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Conversation

sherry-yuan
Copy link
Contributor

@sherry-yuan sherry-yuan commented Feb 8, 2022


Thread sanitizer (TSAN) is a tool that detect data races, deadlocks between threads. (it also sometimes report heap-use-after-free in same thread check #71 for issues reported in current repo)

For more information, checkout https://clang.llvm.org/docs/ThreadSanitizer.html

Addresses #38

@sherry-yuan sherry-yuan mentioned this pull request Feb 8, 2022
@sherry-yuan sherry-yuan self-assigned this Feb 8, 2022
@sherry-yuan sherry-yuan added the enhancement New feature or request label Feb 8, 2022
@sherry-yuan sherry-yuan added this to the 2022.3 milestone Feb 8, 2022
@sherry-yuan sherry-yuan marked this pull request as ready for review February 8, 2022 17:16
@sherry-yuan sherry-yuan requested a review from pcolberg February 8, 2022 17:16
sherry-yuan and others added 2 commits February 16, 2022 20:00
Thread sanitizer (TSAN) is a tool that detect data races and deadlocks between threads. (It also sometimes report heap-use-after-free in same thread check intel#71 for issues reported in current repo)
@pcolberg
Copy link
Contributor

Thanks @sherry-yuan! I revised the CMake code slightly to align with the existing ACL_WITH_ASAN option. We don't currently test with Clang, but it is not too much effort to keep this option open for the future. The C and CXX compilers may theoretically be from a different vendor, so for correctness the compiler ID should be checked separately for each language.

@pcolberg pcolberg merged commit 74507c7 into intel:main Feb 17, 2022
@sherry-yuan
Copy link
Contributor Author

Thanks @pcolberg, will do for future compiler checks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants