Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thread Sanitizer CI/CD #63

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add Thread Sanitizer CI/CD #63

merged 1 commit into from
Mar 4, 2022

Conversation

sherry-yuan
Copy link
Contributor

@sherry-yuan sherry-yuan commented Jan 19, 2022

ThreadSanitizer is a tool that detects data races. It consists of a compiler instrumentation module and a run-time library.

This help us to identify race conditions within the program. It will have greater coverage if we can mock MMD.

Addresses #38

@sherry-yuan
Copy link
Contributor Author

Apparently tsan doesn't work on internal workstations because both the OS and gcc tsan is too old.

So the immediate cause of this problem is that the lsan memory allocator in gcc 8 uses a fixed address of 0x600000000000ULL for starting its memory maps. This is beyond the end of virtual memory for some older kernels (which end at 0x400000000000ULL) but within range for newer ones.

Have to test the flow on using provided images.

@sherry-yuan
Copy link
Contributor Author

sherry-yuan commented Feb 24, 2022

Currently this depend on #71 being fixed for third party libraries, I currently need to focus on a release critical feature before I could get to fixing third party libraries.

I will come back to this likely next week.

@pcolberg
Copy link
Contributor

Thanks @sherry-yuan! Small clarification, acl_threadsupport is a first-party library.

------------------------------

ThreadSanitizer is a tool that detects data races. It consists of a compiler instrumentation module and a run-time library.

This help us to identify race conditions within the program. It will have greater coverage if we can mock MMD.
@pcolberg pcolberg marked this pull request as ready for review March 4, 2022 22:16
@pcolberg pcolberg self-requested a review March 4, 2022 22:17
@pcolberg pcolberg merged commit a7ae1bb into intel:main Mar 4, 2022
@sherry-yuan
Copy link
Contributor Author

Thanks @pcolberg :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants