Implement OpenCL Core 3.0 clCreateBufferWithProperties #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if I should wait until all implementation of core 3.0 is done before making this ready for review. |
pcolberg
requested changes
Jan 12, 2022
There was a problem hiding this comment.
Thanks @sherry-yuan!
I don't see any reason not to merge this right away. @zibaiwan, what do you think?
------------------------------------------------------------- In the most recently imported headers, there is a new function called clCreateBufferWithProperties which is equivalent to our clCreateBufferWithPropertiesINTEL extension function. Implement this function. Closes intel#51
sherry-yuan
force-pushed
the
create_buffer_3
branch
from
c5553bf to
72bf40f
Compare
Thanks @sherry-yuan @pcolberg . I agree this PR can be merged right away. |
zibaiwan
approved these changes
Jan 12, 2022
pcolberg
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the most recently imported headers, there is a new function called clCreateBufferWithProperties which is equivalent to our clCreateBufferWithPropertiesINTEL extension function. Implement this function.
Closes #51