Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compiler-specific hardening flags #48

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Add compiler-specific hardening flags #48

merged 2 commits into from
Jan 27, 2022

Conversation

pcolberg
Copy link
Contributor

No description provided.

@pcolberg pcolberg self-assigned this Dec 16, 2021
@pcolberg pcolberg marked this pull request as draft December 16, 2021 22:54
@pcolberg
Copy link
Contributor Author

pcolberg commented Dec 16, 2021 •
edited
Loading

Still need to resolve glibc warning in Debug mode:

/usr/include/features.h:381:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)

Consider adding -Og in Debug mode which is recommended:

If you are not using some other optimization option, consider using -Og (see Optimize Options) with -g. With no -O option at all, some compiler passes that collect information useful for debugging do not run at all, so that -Og may result in a better debugging experience.

@pcolberg pcolberg added this to the 2022.2 milestone Dec 16, 2021
@pcolberg pcolberg added the enhancement New feature or request label Dec 16, 2021
@pcolberg pcolberg modified the milestones: 2022.2, 2022.3 Jan 20, 2022
@pcolberg pcolberg force-pushed the hardening branch 2 times, most recently from bfd0ef8 to 0ca7740 Compare January 26, 2022 23:44
@pcolberg pcolberg marked this pull request as ready for review January 26, 2022 23:58
@pcolberg pcolberg requested a review from zibaiwan January 26, 2022 23:58
zibaiwan
zibaiwan approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @pcolberg

@pcolberg pcolberg merged commit 67f7f88 into intel:main Jan 27, 2022
@pcolberg pcolberg deleted the hardening branch January 27, 2022 17:03
@pcolberg pcolberg mentioned this pull request May 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zibaiwan zibaiwan zibaiwan approved these changes

Assignees

@pcolberg pcolberg

Labels
enhancement New feature or request
Projects
None yet
Milestone
2022.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pcolberg @zibaiwan