Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added glibc_wrap to provide Linux OS backwards compatibility #362

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jackzhaolt
Copy link
Contributor

@jackzhaolt jackzhaolt commented Jun 4, 2024

Our CI/CD is moving to SUSE15, but we need to support a GLIBC version (2.28) that is below the native GLIBC version on SUSE15)
This change implements a wrapping mechanism that will explicitly link against the older GLIBC functions or syscall functions to the extent required for our oldest supported GLIBC (2.28)

The implementation is based on that used in hld-backend and DSPBA https://github.com/intel-innersource/applications.fpga.oneapi.products.hld-backend-source/pull/510

Tests run:

I've verified with nm that without linking the wrapper, the libalteracl.so file uses GLIBC 2.29 for log operation and GLIBC 2.30 for gettid. With the wrapper it uses glibc2.2.5 for log operation and syscall for gettid.

Local build also passes with this change: https://psg-sc-arc.sc.intel.com/arc/dashboard/reports/show_job/941516093

Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jack, could you also squash the commits since the runtime repo doesn't automatically squash them when merging to the main branch? You should be able to do it through

git rebase -i main # squash the commits into a single one
git push <your_remote> --force-with-lease

@jackzhaolt jackzhaolt force-pushed the main-test-sles15-oneapi branch 9 times, most recently from 8c23714 to 321ed4c Compare June 5, 2024 17:17
@jackzhaolt jackzhaolt requested a review from sophimao June 6, 2024 14:50
@jackzhaolt jackzhaolt force-pushed the main-test-sles15-oneapi branch from 321ed4c to cbed5f8 Compare June 6, 2024 19:44
@sophimao
Copy link
Contributor

CI failure due to actions/runner-images#10004, will bypass CI and merge

@sophimao sophimao merged commit a9bf79e into intel:main Jun 10, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants