Added glibc_wrap to provide Linux OS backwards compatibility #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI/CD is moving to SUSE15, but we need to support a GLIBC version (2.28) that is below the native GLIBC version on SUSE15)
This change implements a wrapping mechanism that will explicitly link against the older GLIBC functions or syscall functions to the extent required for our oldest supported GLIBC (2.28)
The implementation is based on that used in hld-backend and DSPBA https://github.com/intel-innersource/applications.fpga.oneapi.products.hld-backend-source/pull/510
Tests run:
I've verified with nm that without linking the wrapper, the
libalteracl.so
file uses GLIBC 2.29 forlog
operation and GLIBC 2.30 forgettid
. With the wrapper it uses glibc2.2.5 for log operation and syscall forgettid
.Local build also passes with this change: https://psg-sc-arc.sc.intel.com/arc/dashboard/reports/show_job/941516093