Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informally support atomic fence capability device query #345

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

sophimao
Copy link
Contributor

No description provided.

@sophimao sophimao requested a review from zibaiwan March 14, 2024 15:57
@sophimao
Copy link
Contributor Author

Also require DSE change to fully work in SYCL, so making a draft PR for now.

@zibaiwan
Copy link
Contributor

Thread sanitizer failure was strange. Not sure what happened, triggered a rerun.

@zibaiwan
Copy link
Contributor

zibaiwan commented Mar 15, 2024

Thread sanitizer failure was strange. Not sure what happened, triggered a rerun.

Rerun also failed... Checked the OS version between this one and previously passing run, same OS, so should be no difference in the thread sanitizer version. Rerunning the previous passed workflow in another PR: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8071872741?pr=342

@zibaiwan
Copy link
Contributor

Thread sanitizer failure was strange. Not sure what happened, triggered a rerun.

Rerun also failed... Checked the OS version between this one and previously passing run, same OS, so should be no difference in the thread sanitizer version. Rerunning the previous passed workflow in another PR: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8071872741?pr=342

Reran the #342 previously passed workflow in thread sanitizer also failed, so this issue is not related to this PR. I don't know why this started to fail now. The image in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main" has not been updated for 2 months.

@sophimao
Copy link
Contributor Author

The image in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main" has not been updated for 2 months.

Github actions seems to have updated their Ubuntu 22.04 image: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240310.1, could this be related?

@zibaiwan
Copy link
Contributor

The image in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main" has not been updated for 2 months.

Github actions seems to have updated their Ubuntu 22.04 image: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240310.1, could this be related?

Thanks Sophie. Yes, this could be related. Although our image shouldn't have been updated since we built our image based on our custom docker file and store those in the "ghcr.io/intel/fpga-runtime-for-opencl/ubuntu-22.04-dev:main". Those custom images were built 2 months ago. However, maybe I don't know how github images work enough.

Maybe it still grabs the base Ubuntu image (which has the recent update) and then grab the delta changes from our custom image, then combine them to make a whole image, if this is the case, this will explain why this started to fail. I will continue investigating.

@zibaiwan
Copy link
Contributor

I manually triggered a rebuild of all of our container images: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8329819821 here, maybe our custom image didn't play along with the new Ubuntu github image for some reason. Will test CI again after the rebuild.

@zibaiwan
Copy link
Contributor

I manually triggered a rebuild of all of our container images: https://github.com/intel/fpga-runtime-for-opencl/actions/runs/8329819821 here, maybe our custom image didn't play along with the new Ubuntu github image for some reason. Will test CI again after the rebuild.

Nvm, manually triggered event doesn't update the registry due to the if guard in the work flow. Will revisit.

        if: github.event_name == 'push'
        run: docker image push "$image:$tag"

@sophimao sophimao marked this pull request as ready for review March 20, 2024 13:52
@sophimao
Copy link
Contributor Author

Github actions updated their Ubuntu 22.04 image again to https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240317.1, which seems to resolve the thread sanitizer failure.

@sophimao sophimao requested a review from zibaiwan March 20, 2024 13:53
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sophie!

@sophimao sophimao merged commit e62820e into intel:main Mar 20, 2024
23 checks passed
@sophimao sophimao deleted the atomic-fence branch March 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants