Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitary BL for accessor #343

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Support arbitary BL for accessor #343

merged 1 commit into from
Mar 8, 2024

Conversation

zibaiwan
Copy link
Contributor

@zibaiwan zibaiwan commented Feb 29, 2024

Tested with a variety of tests group.

@zibaiwan zibaiwan requested a review from sophimao February 29, 2024 14:50
sophimao
sophimao previously approved these changes Feb 29, 2024
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai! LGTM, just one small nit below that you can make the call whether you want to change it or not :)

@zibaiwan
Copy link
Contributor Author

zibaiwan commented Mar 7, 2024

I made a minor update here in the auto_configure.cpp

std::string gmem_id = "-"; // This should be the default value even if the // auto-discovery string doesn't have this field.

Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai!

@zibaiwan zibaiwan merged commit e4e5b10 into intel:main Mar 8, 2024
23 checks passed
@zibaiwan zibaiwan deleted the a-bf branch March 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants