Delay erasing context from contexts_set during acl_idle_update
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophimao
force-pushed
the
fix-contexts-set
branch
from
e527183 to
e94b8ea
Compare
zibaiwan
previously approved these changes
Oct 20, 2023
Fixes issue where context is being deleted from contexts_set while traversing through the same context_set, causing undefined behaviour and sometimes crash in acl_idle_update.
sophimao
force-pushed
the
fix-contexts-set
branch
from
e94b8ea to
7d4a6f3
Compare
zibaiwan
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where context is being deleted from
contexts_setwhile traversing through the samecontext_set, causing undefined behaviour and sometimes crash inacl_idle_update.