Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simulator device from offline devices #319

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

sophimao
Copy link
Contributor

Simulator device will now be initialized in the same fashion as hardware devices,
during l_initialize_devices. This can be done as we now load simulator device
global memory configuration from the correct autodiscovery string generated by
the system integrator as introduced by commit d57cedc.

@sophimao sophimao requested a review from zibaiwan September 29, 2023 15:09
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sophie! Looks good to me.

@sophimao sophimao merged commit ab09456 into intel:main Oct 3, 2023
@sophimao sophimao deleted the make-sim-online branch October 3, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants