Clean up runtime code for simulation preprogram autodiscovery string load #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophimao
force-pushed
the
sim-preload-string
branch
from
f7af8f9 to
b1bb911
Compare
sophimao
changed the title
sophimao
force-pushed
the
sim-preload-string
branch
from
b1bb911 to
88d2dc8
Compare
sophimao
force-pushed
the
sim-preload-string
branch
from
88d2dc8 to
fb094d5
Compare
zibaiwan
reviewed
Aug 14, 2023
|
Hi Sophie, Thanks for the change. It looks good to me! I think you only ran SYCL tests for the change. Do you mind running a few opencl simulation tests to make sure your change doesn't break OpenCL flow? |
zibaiwan
reviewed
Aug 14, 2023
sophimao
force-pushed
the
sim-preload-string
branch
from
e7c9a66 to
2c974e7
Compare
zibaiwan
reviewed
Aug 16, 2023
zibaiwan
previously approved these changes
Aug 16, 2023
…load Newest simulation runtime allows the autodiscovery string to be read from the same address as in hardware, therefore, this change removes special handling for the simulation flow in the kernel interface initialization.
sophimao
force-pushed
the
sim-preload-string
branch
from
5a006c1 to
790527a
Compare
|
Resolved review comment and squashed commits, @zibaiwan would you mind reviewing again? Thanks! |
zibaiwan
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike in hardware, in simulation the runtime is not able to obtain autodiscovery string
from the device ROM memory before reprogramming, therefore, global memory
configuration information is only available after device reprogram, during which the
autodiscovery string stored in the binary will be extracted. Currently the runtime does
some special handling for the simulation flow to amend for this behavioural difference.
With the newest change to our simulator, the autodiscovery string will be available for read
preprogram and the runtime can now obtain this information just as in the hardware flow
(except for some minor difference). Therefore, this change cleans up the runtime by removing
code for special handling of the simulation flow.