Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AVALON_MM CSR hostpipe #304

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Support AVALON_MM CSR hostpipe #304

merged 1 commit into from
Aug 2, 2023

Conversation

zibaiwan
Copy link
Contributor

@zibaiwan zibaiwan commented Aug 1, 2023

  1. Parse new protocol information from the compiler.
  2. Skip read/write read&valid signal for AVALON_MM

@zibaiwan zibaiwan requested a review from sophimao August 1, 2023 15:21
sophimao
sophimao previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai! Other than some typo/nit this looks good to me!

@zibaiwan zibaiwan requested a review from sophimao August 2, 2023 14:20
@zibaiwan
Copy link
Contributor Author

zibaiwan commented Aug 2, 2023

Thanks Sophie for the review. I have addressed the comments and force pushed my commit.

sophimao
sophimao reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai for the changes, just one small nitpick item and this is good to go!

@zibaiwan zibaiwan requested a review from sophimao August 2, 2023 14:42
sophimao
sophimao approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai!

@zibaiwan zibaiwan merged commit 1b6d4aa into intel:main Aug 2, 2023
@zibaiwan zibaiwan deleted the avalon_mm_final branch August 2, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophimao sophimao sophimao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zibaiwan @sophimao