Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated acl_context_callback With Additional Log #300

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

sharmag1-Gaurav
Copy link
Contributor

With this change, supplying the environment variable ACL_CONTEXT_CALLBACK_DEBUG=1 will make the runtime output the errInfo stored in the acl_context_callback function.

Minor refactoring and moving env strings to header file.

@sharmag1-Gaurav sharmag1-Gaurav requested a review from zibaiwan July 7, 2023 18:48
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gaurav,

Thanks for adding the additional log. The change looks good to me. Please squash the change into 1 commit since the Runtime repo merges multiple commits into the repo to allow one PR to fix multiple issues. In this case, one commit is more suitable since the clang-format is just a fixup.

I will merge once the commit is squashed. Another thing is, I think this will require a doc change in our programming guide, please track that later.

Best regards,

Zibai

@sharmag1-Gaurav sharmag1-Gaurav force-pushed the runtime_error_propagation branch from 0ebe1a8 to 94c0e88 Compare July 11, 2023 17:22
@zibaiwan
Copy link
Contributor

Thanks Gaurav!

@zibaiwan zibaiwan merged commit 2e99b5d into intel:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants