New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device global Dedicated interface Runtime changes. #295

Merged

zibaiwan merged 1 commit into intel:main from zibaiwan:device-global

Jun 23, 2023

Contributor

zibaiwan commented May 26, 2023 •

edited

Loading

Added new command ops and device ops for the clEnqueueReadGlobalVariableINTEL and clEnqueueWriteGlobalVariableINTEL.
Both ops are mainly calling the new MMD read/write functions in the simulator MMD.
Added a brief unit tests for testing the enqueue functionality.

Testing:

Passed the host access device global tests.
Passed integration testing.
L3 tests passed.

zibaiwan changed the title ~~TBD changed, draft for testing device global~~ [Draft] device global runtime change

zibaiwan requested a review from sophimao

June 19, 2023 14:25

zibaiwan marked this pull request as ready for review

June 19, 2023 14:25

zibaiwan changed the title ~~[Draft] device global runtime change~~ Device global Dedicated interface Runtime changes.

sophimao reviewed

View reviewed changes

include/acl_types.h Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

src/acl_device_op.cpp Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

src/acl_device_op.cpp Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

src/acl_mem.cpp Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

src/acl_mem.cpp Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

test/acl_usm_test.cpp Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

test/acl_usm_test.cpp Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

test/acl_usm_test.cpp Outdated Show resolved Hide resolved

zibaiwan requested a review from sophimao

June 20, 2023 17:06

Contributor Author

zibaiwan commented Jun 20, 2023

Thank you very much for your review Sophie. I have resolved all comments. Please take a look when you have time.

sophimao reviewed

View reviewed changes

src/acl_mem.cpp Outdated Show resolved Hide resolved

sophimao reviewed

View reviewed changes

Contributor

sophimao left a comment

Thanks Zibai! Other than a small typo this looks good to me.

Contributor Author

zibaiwan commented Jun 20, 2023

Thanks Sophie. I will be running L3 testing and will rebase&squash the commits for you to do the final approval once the testing is done.

sophimao reviewed

View reviewed changes

src/acl_mem.cpp Outdated Show resolved Hide resolved


          Device global Dedicated interface Runtime changes

565a712

1. Added new command ops and device ops for the clEnqueueReadGlobalVariableINTEL and clEnqueueWriteGlobalVariableINTEL.
2. Both ops are mainly calling the new MMD read/write functions in the simulator MMD.
3. Added a brief unit test for testing the enqueue functionality.

zibaiwan force-pushed the device-global branch from 5c120bd to 565a712 Compare

June 23, 2023 13:34

Contributor Author

zibaiwan commented Jun 23, 2023

@sophimao , testing completed and the result looks good. I have squashed the commits. Thanks!

zibaiwan requested a review from sophimao

June 23, 2023 13:37

sophimao approved these changes

View reviewed changes

Contributor

sophimao left a comment

Thanks Zibai!

zibaiwan merged commit 8cfe0db into intel:main

zibaiwan deleted the device-global branch

June 23, 2023 13:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet