Fix kernel id - CSR address mapping issue #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zibaiwan , this is the change to runtime I mentioned before, would you mind taking a look? Thanks! |
zibaiwan
previously approved these changes
Apr 5, 2023
zibaiwan
reviewed
Apr 5, 2023
sophimao
force-pushed
the
host-pipe-stage
branch
from
a97edb1 to
156404c
Compare
Currently simulation uses arithmetics to derive kernel id and csr start register address, which is error prone. This change adds a new MMD call to pass kernel-id to csr address mapping to the lower runtime so it could use the information directly.
sophimao
force-pushed
the
host-pipe-stage
branch
from
156404c to
cec7b9b
Compare
|
Hi @zibaiwan , sorry but looks like updating commit message invalidates your review, would you mind approving again? |
zibaiwan
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in simulation we need to match CSR address with kernel id in order to know which start register the runtime is writing into and set the corresponding start signal in the simulation control BFM. This change sends the kernel id CSR address mapping information to the simulation runtime through a new simulation MMD function.