Add accel_id parameter to simulation_streaming_kernel_start() function
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlanTruanovsky
force-pushed
the
sim-stream-cra
branch
2 times, most recently
from
b54670c to
a6c4dfc
Compare
|
@pcolberg this is ready for review now. Thanks! |
IlanTruanovsky
changed the title
done_cra_writes function to the HAL
IlanTruanovsky
changed the title
done_cra_writes function to the HALsimulation_streaming_interface_done_cra_writes function to the HAL
pcolberg
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Thanks @IlanTruanovsky, looks good. Passing on to @zibaiwan for final review.
|
I have changed the implementation to only modify the I'll rebase once internal testing has passed. In the meantime, can @pcolberg take another look? |
zibaiwan
previously approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Thanks Ilan and Peter. The change looks good to me. We can merge once the integration testing passed. Ilan please provide a descriptive commit message briefly explaining why the mmd API changed and what's the accel_id used for while you are rebasing (basically what you have in the PR description).
IlanTruanovsky
changed the title
simulation_streaming_interface_done_cra_writes function to the HALaccel_id parameter to simulation_streaming_kernel_start() function
IlanTruanovsky
force-pushed
the
sim-stream-cra
branch
2 times, most recently
from
d22a7b4 to
7a8eab7
Compare
…ction This commit changes the signature of the `simulation_streaming_kernel_start()` function to allow for the code to pass in an `accel_id` argument. The purpose of this parameter is to tell the simulator which kernel should start. The simulator uses this information to send a start signal to the kernel with id `accel_id`.
IlanTruanovsky
force-pushed
the
sim-stream-cra
branch
from
7a8eab7 to
5d50227
Compare
zibaiwan
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the signature of the
simulation_streaming_kernel_start()function to allow for the code to pass in anaccel_idargument. The purpose of this parameter is to tell the simulator which kernel should start. The simulator uses this information to send a start signal to the kernel with idaccel_id.