Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto discovery change for device global #278

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

intel-liudean
Copy link
Contributor

@intel-liudean intel-liudean commented Feb 15, 2023

For each device global, the init_mode field is changed to can_skip_programming field, a new field reset_on_reuse is added at the end.

@zibaiwan
Copy link
Contributor

@intel-liudean , thanks for working on this!

I haven't finished the review yet but I think you need to make more updates in the acl_auto_configure_test.cpp. Take a look at the Sophie's change earlier: 6f68280, there are many hard-coded device global in several tests, all of them require fields update I believe.

Also please squash those two commits into 1 single commit and provide the description in the commit message and in the PR title. Thanks!

For each device global, the init_mode field is changed to can_skip_programming field, a new field reset_on_reuse is added at the end.
@intel-liudean
Copy link
Contributor Author

@intel-liudean , thanks for working on this!

I haven't finished the review yet but I think you need to make more updates in the acl_auto_configure_test.cpp. Take a look at the Sophie's change earlier: 6f68280, there are many hard-coded device global in several tests, all of them require fields update I believe.

Also please squash those two commits into 1 single commit and provide the description in the commit message and in the PR title. Thanks!

I have addressed your feedback @zibaiwan. Please take a look again.

@intel-liudean intel-liudean requested a review from sophimao March 14, 2023 15:38
@zibaiwan zibaiwan changed the title Auto discovery change Auto discovery change for device global Mar 21, 2023
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@zibaiwan zibaiwan merged commit 0f8829f into intel:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants