Fix Coverity issues for acl_mem_test.cpp
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in intel@2834ca2. Fixes: ``` test/acl_mem_test.cpp:1610:11: Type: Invalid type in argument to printf format specifier (PRINTF_ARGS) test/acl_mem_test.cpp:1610:11: invalid_type: Argument "trial" to format specifier "%d" was expected to have type "int" but has type "unsigned long". src/acl_hal.cpp:123:3: path: Condition "debug_mode > 0", taking true branch. src/acl_hal.cpp:126:5: printf_function: Calling "vprintf" which uses a "printf"-style format string. [Note: The source code implementation of the function has been overridden by a builtin model.] ```
Many arrays where unitizialized in `acl_mem_test.cpp` which caused Coverity to complain. The Coverity output for these issues is very large, so I'll refrain from posting it here.
pcolberg
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of fixes:
PRINTF_ARGSCoverity issue was missed in 2834ca2The Coverity issues that were resolved have a lot of output, so I'll refrain from displaying them here.